-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release 1.69.1 to develop #4489
Conversation
This updates translations after running `npm run bundle`
Release 1.69.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM. Thanks for updating develop
, @mkevins . :)
@@ -7,16 +7,21 @@ Unreleased | |||
* [*] Fix missing translations of color settings [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4479] | |||
* [*] Fix cut-off setting labels by properly wrapping the text [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4475] | |||
* [*] Highlight text: fix applying formatting for non-selected text [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4471] | |||
* [**] Fix Android handling of Hebrew and Indonesian translations [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4397] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this was moved to Unreleased
as it sounds like it was merged to develop
after we cut the beta fix. I haven't confirmed timing of anything, but I saw that there was a pending question here. Was this confirmed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this looks like it was auto-resolved incorrectly by git (the PR had been created prior to the release branch, but it didn't land until after the cut, so it was actually in the "Unreleased" section of the notes in the PR itself. It seems that when it was merged into develop
, the new version headings were already present in the notes, but this line was added under them, when it should have been "bumped" back up to the "new" "unreleased" section.
The pending question there would be a good confirmation, but is mostly relevant for the current release wranglers of the 1.70.0
release, so they have clarity on where that note belongs.
Thanks for reviewing @ttahmouch ! |
This PR merges the 1.69.1 betafix release back to
develop
.PR submission checklist: